action: Add dialog to markNarrowAsRead for CombinedFeedNarrow view #2006
Conversation
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks! Comments below.
lib/widgets/actions.dart
Outdated
| static Future<void> markNarrowAsRead(BuildContext context, Narrow narrow) async { | ||
| final zulipLocalizations = ZulipLocalizations.of(context); | ||
|
|
||
| if (narrow is CombinedFeedNarrow) { |
There was a problem hiding this comment.
The issue asks for the dialog to be shown in more than just the combined-feed narrow: #1858 (comment)
chungwwei
force-pushed
the
read-confirm-dialog
branch
from
1de2a51 to
970aee6
Compare
|
@chrisbobbe Thanks for reviewing! Squash the 4 commits into one.
|
That's not accurate. We should show the dialog when the narrow is not a conversation narrow. A "conversation narrow" is a topic narrow or a DM narrow; see e.g. the top of the Zulip Help Center "Reading conversations" article. These details are provided for you in the issue description and discussions linked from there. In the zulip-flutter codebase, there are multiple kinds of |
chungwwei
force-pushed
the
read-confirm-dialog
branch
2 times, most recently
from
f51a3f4 to
9b5a5e3
Compare
A confirm ActionDialog is added to prevent accidentally marking many messages as read in CombinedFeedNarrow view. Also, adjust existing MarkAsReadWidget tests to account for the added confirmation dialog. Fixes: part of zulip#1858
Added dialog to prevent accidentally marking many messages as read in ChannelNarrow View. Also, adjust existing MarkChannelAsReadButton tests to account for the added confirmation dialog. Fixes: part of zulip#1858
chungwwei
force-pushed
the
read-confirm-dialog
branch
2 times, most recently
from
f900adb to
f6a1cee
Compare
chungwwei
force-pushed
the
read-confirm-dialog
branch
from
f6a1cee to
712aa85
Compare
3 participants
Fixes: #1858
Still picture
Screencasts
combined feed narrow
combined_feed_sc.mp4
channel narrow
channel_sc.mp4
mentions narrow
mention_sc.mp4